-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve errors definition and docs #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I reviewed most error comments. But I didn't quite understand what this is trying to say: https://github.com/opentensor/subtensor/pull/433/files#diff-1d0c66ee439b9d6f7f2d63b75825a63ca6af50725485830095562b200aadbf6cR193
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestions. Approving. Terrific work! Your work in this PR alone will lift up the user experience considerbly, thanks!
Description
Right now a lot of the errors returned by subtensor extrinsics are fairly generic substrate errors. We want these to be as granular / descriptive as possible, so an audit of what errors we are returning should be conducted and we should create new error types and/or utilize existing descriptive ones wherever possible
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.