Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/pending emission migration patch and fix set weights check #809

Merged
merged 17 commits into from
Sep 17, 2024

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Sep 13, 2024

Description

This PR: was realized via tests on the mainnet clone before pushing to the mainnet

  • patches the migration for PendingdHotkeyEmission and adds tests to verify
    • also verified using the mainnet clone
  • patches the set_weights call for childkeys and adds tests to verify
    • also verified using the mainnet clone
    • prevents regression with an extra test for regular hotkeys

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@camfairchild camfairchild changed the title Hotfix/pending emission migration patch Hotfix/pending emission migration patch and fix set weights check Sep 13, 2024
@unconst unconst merged commit af585b9 into main Sep 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants