Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower faucet diff to 100 on fast-blocks #944

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Nov 7, 2024

Description

This PR lowers the faucet diff to 100 if the feature flag of fast-blocks is used.
This allows the faucet to be used during e2e tests, etc., which use the fast-blocks flag and would be
impacted by the faucet POW taking too long.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@camfairchild camfairchild changed the title lower faucet diff to 1k lower faucet diff to 100 on fast-blocks Nov 7, 2024
@camfairchild camfairchild marked this pull request as ready for review November 8, 2024 15:10
@camfairchild camfairchild requested a review from unconst as a code owner November 8, 2024 15:10
@camfairchild camfairchild requested a review from sam0x17 November 8, 2024 16:48
@unconst unconst merged commit 4b45cd3 into devnet-ready Nov 12, 2024
8 checks passed
@camfairchild camfairchild deleted the feat/lower-facuet-diff branch November 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants