Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add removed main changes #945

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

gztensor
Copy link
Contributor

@gztensor gztensor commented Nov 7, 2024

Description

Adds back

  • migration migrate_pending_emissions_including_null_stake (which is not executed) and its test
  • Two swap_hotkey tests:
    • test_hotkey_swap_stake_delta
    • test_swap_hotkey_with_pending_emissions

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): resolving old merge

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

n/a

Additional Notes

n/a

@gztensor gztensor requested a review from unconst as a code owner November 7, 2024 23:15
@unconst unconst merged commit 31d801e into devnet-ready Nov 8, 2024
8 checks passed
@distributedstatemachine distributedstatemachine deleted the fix/reapply-reverted-main-updates branch November 9, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants