Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Moved React to a Peer Dependency (and Dev Dependency) #21

Merged
merged 2 commits into from
Aug 14, 2017

Conversation

riceboyler
Copy link

Reusable React components shouldn't have React as a pure dependency due to versioning issues. In this PR, I moved React to a peerDependency and devDependency in order to resolve an issue with versioning we're having at our company.

For more information about React and dependencies, see this link: https://stackoverflow.com/questions/30451556/what-is-the-correct-way-of-adding-a-dependency-to-react-in-your-package-json-for

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
@aiham
Copy link
Contributor

aiham commented Aug 14, 2017

@riceboyler Thanks! Could you please remove the .idea/workspace.xml file?

@aiham aiham changed the base branch from master to dev August 14, 2017 15:20
@riceboyler
Copy link
Author

Done, sorry about that. I thought I had removed it.

@aiham aiham changed the base branch from dev to master August 14, 2017 15:25
@aiham aiham changed the base branch from master to dev August 14, 2017 15:25
@aiham aiham merged commit 9aa76cd into opentok:dev Aug 14, 2017
@riceboyler
Copy link
Author

Thanks for the QUICK work on this!

@riceboyler riceboyler deleted the reactPeerDependency branch August 14, 2017 15:27
@riceboyler
Copy link
Author

@aiham Any idea what's causing the build to fail? Looks like a specific library that Chrome needs is failing.

@aiham
Copy link
Contributor

aiham commented Aug 14, 2017 via email

@ckuiawa
Copy link

ckuiawa commented Aug 16, 2017

Are you going to be able to release a version with this change? The alternative is that I need to fork this repo, change the package name, apply this fix, publish to my local npm server, and change my projects that depend on this.

@aiham
Copy link
Contributor

aiham commented Aug 18, 2017

@riceboyler Yeah upgrading to Ubuntu Trusty did the trick: https://travis-ci.org/aiham/opentok-react/builds/265806471

@aiham
Copy link
Contributor

aiham commented Aug 18, 2017

@riceboyler @ckuiawa Published to npm as v0.7.0

@ckuiawa For future reference, you can reference a package that hasn't been published to npm but is on github:

  "dependencies": {
    "opentok-react": "aiham/opentok-react#dev"
  }

The phrase after the # is the desired branch name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants