Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include images into vite build process so urls are transformed correctly #5579

Conversation

testower
Copy link
Contributor

Summary

This moves images from public folder into src and uses imports to allow Vite to transform URLs. Note that some images are bundled into the transpiled code as data urls, since they are very small (most of the mode icons).

This PR would be a prerequisite for #5578 to work correctly with images.

Issue

#5330

@testower testower requested a review from a team as a code owner December 18, 2023 09:45
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df9e1e1) 67.35% compared to head (ea76def) 67.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5579   +/-   ##
==========================================
  Coverage      67.35%   67.35%           
  Complexity     16150    16150           
==========================================
  Files           1857     1857           
  Lines          71075    71075           
  Branches        7402     7402           
==========================================
  Hits           47872    47872           
  Misses         20745    20745           
  Partials        2458     2458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried merged commit c766bde into opentripplanner:dev-2.x Dec 19, 2023
5 checks passed
@testower testower deleted the debug-client-bundle-image-assets branch December 19, 2023 19:55
@t2gran t2gran added this to the 2.5 (next release) milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants