Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of @Nonnull annotation #6122

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

optionsome
Copy link
Member

Summary

We decided that @Nonnull annotation should not be used since it's the default behaviour when @Nullable is not used. This removes the the usage of the annotation.

Issue

This is related to #6095

Unit tests

Only automated updates.

Documentation

No updates, updates are done within the scope of #6095

Changelog

Skipped

@optionsome optionsome requested a review from a team as a code owner October 8, 2024 12:13
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (233674c) to head (fbe3a24).
Report is 3 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...entripplanner/ext/reportapi/model/CachedValue.java 0.00% 1 Missing ⚠️
...rg/opentripplanner/graph_builder/GraphBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6122      +/-   ##
=============================================
- Coverage      69.85%   69.85%   -0.01%     
+ Complexity     17497    17496       -1     
=============================================
  Files           1976     1976              
  Lines          74710    74710              
  Branches        7645     7645              
=============================================
- Hits           52191    52189       -2     
- Misses         19868    19870       +2     
  Partials        2651     2651              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried
Copy link
Member

You have conflicts

@optionsome optionsome merged commit 236aa83 into opentripplanner:dev-2.x Oct 8, 2024
5 checks passed
@optionsome optionsome deleted the remove-nonnull branch October 8, 2024 14:08
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants