Timetable snapshot code cleanup #6124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpaturet
added
Technical Debt
Real-Time Update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6124 +/- ##
=============================================
- Coverage 69.85% 69.85% -0.01%
+ Complexity 17497 17492 -5
=============================================
Files 1976 1976
Lines 74710 74706 -4
Branches 7645 7645
=============================================
- Hits 52191 52187 -4
Misses 19868 19868
Partials 2651 2651 ☔ View full report in Codecov by Sentry. |
vpaturet
force-pushed
the
timetable_snapshot_code_cleanup
branch
from
cb53d81
to
f91acf8
Compare
vpaturet
force-pushed
the
timetable_snapshot_code_cleanup
branch
3 times, most recently
from
9681194
to
466c4a9
Compare
vpaturet
force-pushed
the
timetable_snapshot_code_cleanup
branch
from
466c4a9
to
b451cbb
Compare
| * TODO RT_AB: clarify if this is an index or the original source of truth. | ||
| */ | ||
| private final Map<TripIdAndServiceDate, TripPattern> realtimeAddedTripPattern; | ||
| private final Map<TripIdAndServiceDate, TripPattern> realTimeModifiedTripPattern; |
There was a problem hiding this comment.
My suggestion is to call this realTimeNewTripPatternsForModifiedTrips. It is long and ugly but at least it is very specific and shouldn't cause any confusion. We can rename it to something simpler later after we've cleaned up the code.
vpaturet
force-pushed
the
timetable_snapshot_code_cleanup
branch
from
70a7ba3
to
3659670
Compare
| @@ -604,6 +600,12 @@ private void swapTimetable(TripPattern pattern, Timetable original, Timetable up | |||
| dirty = true; | |||
| } | |||
|
|
|||
| private void validateReadOnly() { | |||
There was a problem hiding this comment.
I would call this validateNotReadOnly() or validateWritable() or throwIfReadOnly()
vpaturet
force-pushed
the
timetable_snapshot_code_cleanup
branch
from
eee401f
to
28fc2e4
Compare
vpaturet
force-pushed
the
timetable_snapshot_code_cleanup
branch
from
28fc2e4
to
6113d1d
Compare
leonardehrenfried
approved these changes
Oct 9, 2024
habrahamsson-skanetrafiken
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code clean-up and documentation/clarification in TimetableSnapshot:
Issue
#6048
Unit tests
No
Documentation
No