Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jar and src location in docs and client codegen #6161

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

optionsome
Copy link
Member

@optionsome optionsome commented Oct 15, 2024

Summary

This updates the jar and src location in docs. It also fixes transmodel schema location used in client codegen. Localization.md file is removed since we don't want to update the legacy debug client anymore.

Issue

no issue

Unit tests

no tests

Documentation

Updated docs

Changelog

Skipped

@optionsome
Copy link
Member Author

The scripts located in /scripts folder seem to be broken in multiple ways. I didn't fix them at least for now but probably should since there is a reference to the otp script in docs.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.90%. Comparing base (6b3ba97) to head (243c232).
Report is 59 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6161   +/-   ##
==========================================
  Coverage      69.90%   69.90%           
+ Complexity     17711    17710    -1     
==========================================
  Files           1996     1996           
  Lines          75328    75328           
  Branches        7713     7713           
==========================================
  Hits           52660    52660           
  Misses         19992    19992           
  Partials        2676     2676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +69 to +73
(the external libraries they use). The shell script called 'otp' in the root of the cloned repository
will start the main class of that JAR file under a Java virtual machine, so after the Maven build
completes you should be able to run `./otp --help` and see an OTP help message including command line
options. Due to the way Maven works, this script is not executable by default, so you will need to do
`chmod u+x ./otp` before you run it to mark it as executable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shell script doesn't exist any more but that's beyond the scope of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does exist (along side with a couple of others), @t2gran moved them to script directory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as stated in #6161 (comment), there are a few issues with the scripts as far as I can tell.

@@ -1,229 +0,0 @@
# Localization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
@testower testower self-requested a review October 16, 2024 19:09
@optionsome optionsome merged commit 612df9c into opentripplanner:dev-2.x Oct 17, 2024
6 checks passed
@optionsome optionsome deleted the fix-docs-jar-location branch October 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants