Change the NeTEx mapping of "cableway" to GONDOLA #6174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
This change should be unproblematic for us at ENTUR and in Skaane. I only see one theoretical pitfall here. If you mix NeTEx data with the GTFS API or The NeTEx API with GTFS data it might have some side effects. But, in our case tha only thing that chaged is the internal state of OTP. Thank you for the contribution and the added tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6174 +/- ##
==========================================
Coverage 69.93% 69.93%
+ Complexity 17730 17728 -2
==========================================
Files 1996 1996
Lines 75402 75402
Branches 7717 7717
==========================================
Hits 52731 52731
+ Misses 19995 19994 -1
- Partials 2676 2677 +1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
added
the
bump serialization id
|
I'm bumping the serialisation id because you need to rebuild the graph in oder to get the correct mode. |
optionsome
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the NeTEx mapping of "cableway" to GONDOLA. It is currently CABLE_CAR, but it is GTFS (American) terminology where a cable car is a street-level rail vehicle propelled by trams, while in Transmodel, a cableway is a form of transport which vehicles are suspended from a cable.
Issue
google/transit#186
Unit tests
Added for cableway mapping.
Documentation
None here, but #6173 is relevant.