Remove legacy bike access mapping

[leonardehrenfried]

Summary

This removes the parsing of legacy bikes_allowed information. The fields trip_bikes_allowed and route_bikes_allowed were discussed early in the GTFS spec process but have never made it into the specification.

It has been deprecated in onebusaway-gtfs for many years and removed in the latest version.

Issue

None.

Unit tests

Existing ones updated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (9812c5b) to head (d2cf56f).
Report is 78 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6248      +/-   ##
=============================================
- Coverage      69.73%   69.71%   -0.03%     
- Complexity     17680    17693      +13     
=============================================
  Files           2007     2008       +1     
  Lines          75771    75827      +56     
  Branches        7754     7762       +8     
=============================================
+ Hits           52842    52864      +22     
- Misses         20217    20252      +35     
+ Partials        2712     2711       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• JS Bundle Analysis - Avoid shipping oversized bundles

[flaktack]

The simple test GTFS contains both route_bikes_allowed and trip_bikes_allowed columns. Should those be removed, replaced with the standard versions?

OpenTripPlanner/application/src/test/resources/gtfs/simple/routes.txt

Line 1 in 5b5d92f

route_id,route_short_name,route_long_name,route_type,route_bikes_allowed

OpenTripPlanner/application/src/test/resources/gtfs/simple/trips.txt

Line 1 in 5b5d92f

route_id,service_id,trip_id,shape_id,block_id,wheelchair_accessible,trip_bikes_allowed,direction_id,trip_headsign

[flaktack]

bikes_allowed only seems to be present in trips.txt. Should the route based handling also be removed?
https://gtfs.org/documentation/schedule/reference/#routestxt

[leonardehrenfried]

You're totally right - this is actually not part of the spec.

I think I want to ask around if this is really not in use by the current users (HSL, IBI, RealCity) and then open another PR.

[leonardehrenfried]

I would also have a knock-on effect on the Route type so that would also require more discussion.

[optionsome]

Pretty sure we don't have the bikes_allowed information in routes.txt in any of our data sets.

[leonardehrenfried]

The simple test GTFS contains both route_bikes_allowed and trip_bikes_allowed columns. Should those be removed, replaced with the standard versions?

OpenTripPlanner/application/src/test/resources/gtfs/simple/routes.txt

Line 1 in 5b5d92f

route_id,route_short_name,route_long_name,route_type,route_bikes_allowed

OpenTripPlanner/application/src/test/resources/gtfs/simple/trips.txt

Line 1 in 5b5d92f

route_id,service_id,trip_id,shape_id,block_id,wheelchair_accessible,trip_bikes_allowed,direction_id,trip_headsign

Good catch. Updated.