Fix problem with relaxed-generalized-cost-at-destination #6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6255 +/- ##
==========================================
Coverage 69.71% 69.71%
- Complexity 17697 17702 +5
==========================================
Files 2008 2008
Lines 75836 75841 +5
Branches 7766 7767 +1
==========================================
+ Hits 52869 52876 +7
+ Misses 20252 20250 -2
Partials 2715 2715 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
flaktack
reviewed
Nov 15, 2024
...opentripplanner/routing/algorithm/raptoradapter/transit/mappers/RaptorRequestMapperTest.java
Outdated
Show resolved
Hide resolved
...opentripplanner/routing/algorithm/raptoradapter/transit/mappers/RaptorRequestMapperTest.java
Outdated
Show resolved
Hide resolved
…ia-visit, and any combination of via-pass-through and relaxed-cost.
t2gran
force-pushed
the
transit-group-priority-and-via-bug
branch
from
e8361a4
to
e9aa493
Compare
leonardehrenfried
approved these changes
Nov 19, 2024
flaktack
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the the
relaxGeneralizedCostAtDestinationwitch does not work after #6253. It also make the mapping of the RaptorRequest more readable.Issue
🟥 No issue for this. This is done on top of PR #6253, and need to be rebased when it is merged.
Unit tests
✅ A new test is added witch test a all combinations of "compeating" features in the RaptorRequestMapper.
Documentation
🟥 No extra doc is added, except a few comments to clearify the implementation.
Changelog
🟥 This bug is introduced in #6253.
Bumping the serialization version id
🟥 Not needed, only mapping code is changed.