feat(heat pump): Expose heating.spf.* data points (#490)

expose heating.spf
openviess · Jan 22, 2025 · ee3bbfa · ee3bbfa
1 parent ff1460d
commit ee3bbfa
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/PyViCare/PyViCareHeatPump.py b/PyViCare/PyViCareHeatPump.py
@@ -250,6 +250,18 @@ def getSupplyPressure(self) -> float:
         # Returns heating supply pressure
         return float(self.service.getProperty("heating.sensors.pressure.supply")["properties"]["value"]["value"])
 
+    @handleNotSupported
+    def getSeasonalPerformanceFactorDHW(self) -> float:
+        return float(self.service.getProperty("heating.spf.dhw")["properties"]["value"]["value"])
+
+    @handleNotSupported
+    def getSeasonalPerformanceFactorHeating(self) -> float:
+        return float(self.service.getProperty("heating.spf.heating")["properties"]["value"]["value"])
+
+    @handleNotSupported
+    def getSeasonalPerformanceFactorTotal(self) -> float:
+        return float(self.service.getProperty("heating.spf.total")["properties"]["value"]["value"])
+
 
 class Compressor(HeatingDeviceWithComponent):
 

diff --git a/tests/test_TestForMissingProperties.py b/tests/test_TestForMissingProperties.py
@@ -104,9 +104,6 @@ def test_missingProperties(self):
             'heating.scop.dhw', # deprecated
             'heating.scop.heating', # deprecated
             'heating.scop.total', # deprecated
-            'heating.spf.dhw',
-            'heating.spf.heating',
-            'heating.spf.total',
         ]
 
         all_features = self.read_all_features()

diff --git a/tests/test_Vitocal250A.py b/tests/test_Vitocal250A.py
@@ -197,3 +197,8 @@ def test_getDomesticHotWaterStorageTemperature(self):
     def test_getSupplyPressure(self):
         self.assertEqual(self.device.getSupplyPressure(), 2.1)
         self.assertEqual(self.device.getSupplyPressureUnit(), "bar")
+
+    def test_getSeasonalPerformanceFactor(self):
+        self.assertEqual(self.device.getSeasonalPerformanceFactorDHW(), 4.1)
+        self.assertEqual(self.device.getSeasonalPerformanceFactorHeating(), 3.2)
+        self.assertEqual(self.device.getSeasonalPerformanceFactorTotal(), 3.9)