fix(trv): use device.name to determine device serial (#469)

add getSerial for TRV
openviess · Dec 19, 2024 · f1a1512 · f1a1512
1 parent b2addf6
commit f1a1512
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/PyViCare/PyViCareRadiatorActuator.py b/PyViCare/PyViCareRadiatorActuator.py
@@ -4,6 +4,10 @@
 
 class RadiatorActuator(Device):
 
+    @handleNotSupported
+    def getSerial(self):
+        return self.service.getProperty("device.name")["deviceId"]
+
     @handleNotSupported
     def getTemperature(self):
         return self.service.getProperty("device.sensors.temperature")["properties"]["value"]["value"]

diff --git a/tests/test_zigbee_zk03839.py b/tests/test_zigbee_zk03839.py
@@ -9,6 +9,9 @@ def setUp(self):
         self.service = ViCareServiceMock('response/zigbee_zk03839.json')
         self.device = RoomSensor(self.service)
 
+    def test_getSerial(self):
+        self.assertEqual(self.device.getSerial(), "zigbee-2c1165fffe977770")
+
     def test_isDomesticHotWaterDevice(self):
         self.assertEqual(self.device.isDomesticHotWaterDevice(), False)
 

diff --git a/tests/test_zigbee_zk03840.py b/tests/test_zigbee_zk03840.py
@@ -9,6 +9,9 @@ def setUp(self):
         self.service = ViCareServiceMock('response/zigbee_zk03840_trv.json')
         self.device = RadiatorActuator(self.service)
 
+    def test_getSerial(self):
+        self.assertEqual(self.device.getSerial(), "zigbee-048727fffe196e03")
+
     def test_isDomesticHotWaterDevice(self):
         self.assertEqual(self.device.isDomesticHotWaterDevice(), False)