Add Support for HEMS, VX3 and other EES Devices #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! |
20 tasks
CFenner
pushed a commit
to CFenner/PyViCare
that referenced
this pull request
Dec 26, 2023
* add Device for HEMS and ElectricalEnergySystems * add missing Properties for HEMS Device * add a missing Property and format the File * change dependency from HeatingDevice to Device * update comments * fix wrong output for ess.power unit * add test and test data for Vitocharge VX3
CFenner
reviewed
Jan 25, 2024
| (self.asRoomSensor, r"E3_RoomSensor", ["type:climateSensor"]) | ||
| (self.asRoomSensor, r"E3_RoomSensor", ["type:climateSensor"]), | ||
| (self.asElectricalEnergySystem, r"E3_HEMS", ["type:hems"]), | ||
| (self.asElectricalEnergySystem, r"E3_TCU10_x07", ["type:tcu"]), |
There was a problem hiding this comment.
@Nibot1, why did you choose to handle the tcu as an ElectricalEnergySystem? Due to it's device id gateway which is set to 0 in PyViCare.py this leads to duplicating device 0. Instead this should be handled as gateway (recently added class) to expose its feature (currently only wifi strength). What do you think?
There was a problem hiding this comment.
Hi, apologies for my delayed response. You are right, we should handle the TCU as a Gateway. At the time when I implemented this, I didn't exactly know what the meaning of TCU was. Now I think TCU is Transmission Control Unit, is this right?
There was a problem hiding this comment.
I think so too, but I don't have the device in my setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add Data Point Support for:
Data points that would be supported: ess.* photovoltaic.* pcc.*
Sadly, to use these Data Points, you need the Advanced or Electric Subscription.