Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testdata): Update Vitodens 050W data #486

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

joearkay
Copy link
Contributor

Overwritten & sorted file. Unable to re-use previous PR as got my branches in a muddle. Sorry.

Copy link
Member

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please look at the indentation, that seems to be a different one.

@CFenner
Copy link
Member

CFenner commented Jan 21, 2025

@joearkay I did the sorting myself, as you can see there are not that many changes.You seem to have no circulation pump active, but instead some DHW modes.

We need to adapt the tests to you values though.

@CFenner CFenner changed the title Update Vitodens050W.json chore(testdata): Update Vitodens 050W data Jan 22, 2025
@CFenner CFenner merged commit 6a0910e into openviess:master Jan 22, 2025
9 checks passed
@joearkay
Copy link
Contributor Author

@CFenner thanks, you got to it faster than I did. Ok great, I will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants