-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove config from torch inferencer #1001
Remove config from torch inferencer #1001
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, my main question is do we want to support exporting to both torch and openvino format within the same run. In that case we would need to make some changes to how we configure the export.
model_source (str | Path | AnomalyModule): Path to the model ckpt file or the Anomaly model. | ||
metadata_path (str | Path, optional): Path to metadata file. If none, it tries to load the params | ||
from the model state_dict. Defaults to None. | ||
path (str | Path | AnomalyModule): Path to the model ckpt file or the Anomaly model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated (I think we only support str
and Path
now, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any additional comments.
…t-akcay/anomalib into remove-config-from-torch-inferencer
…t-akcay/anomalib into remove-config-from-torch-inferencer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sorting this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
config
fromTorchInferencer
Changes
Checklist