Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure reference frame for multi-frame video clips #1023

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Apr 21, 2023

Description

  • In multi-frame video pipelines, we need to set which frame acts as the reference frame, meaning the ground truth information of that frame will be used to represent the (multi-frame) video clip.
  • This PR makes this configurable from the config. The user may elect to take the GT info from the first frame, last frame, mid frame or all frames combined.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added the Docs label Apr 21, 2023
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only few comments

src/anomalib/data/base/video.py Show resolved Hide resolved
src/anomalib/post_processing/visualizer.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. One minor comment

src/anomalib/data/base/video.py Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me

src/anomalib/data/base/video.py Show resolved Hide resolved
@samet-akcay samet-akcay merged commit 7ef59f9 into openvinotoolkit:main Apr 24, 2023
@djdameln djdameln deleted the video-gt-handling branch December 4, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants