Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python to 3.10 #1035

Merged
merged 18 commits into from
May 12, 2023
Merged

Conversation

samet-akcay
Copy link
Contributor

Description

  • Upgrade python to 3.10

  • Fixes CVS-105481

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have a few comments.

@@ -21,7 +21,7 @@ RUN apt-get update && \
curl \
wget \
ffmpeg \
libpython3.8 \
libpython3.10 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work on your machine? I tried building the docker image and I get this error Unable to locate package libpython3.10

@@ -45,7 +45,7 @@ RUN curl https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh >
bash ~/miniconda.sh -b -p /home/user/conda && \
rm ~/miniconda.sh
ENV PATH "/home/user/conda/bin:${PATH}"
RUN conda install python=3.8
RUN conda install python=3.10

# Prettier requires atleast nodejs 10 and actions/checkout requires nodejs 16
RUN curl -sL https://deb.nodesource.com/setup_current.x > nodesetup.sh && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR. I should have checked this earlier but node setup fails as it runs under non-root user. Can you move this below line 37.

rm -rf /var/lib/apt/lists/*

# Prettier requires atleast nodejs 10 and actions/checkout requires nodejs 16
RUN curl -sL https://deb.nodesource.com/setup_current.x > nodesetup.sh && \
    bash - nodesetup.sh && \
    apt-get install --no-install-recommends -y nodejs && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/*

Comment on lines +41 to +42
- python-version: "3.10"
tox-env: "py310"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to add more versions to the matrix?

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 0ae3e6f into openvinotoolkit:main May 12, 2023
@samet-akcay samet-akcay deleted the python310 branch May 12, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants