-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade python to 3.10 #1035
Upgrade python to 3.10 #1035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have a few comments.
.ci/cuda10.2.Dockerfile
Outdated
@@ -21,7 +21,7 @@ RUN apt-get update && \ | |||
curl \ | |||
wget \ | |||
ffmpeg \ | |||
libpython3.8 \ | |||
libpython3.10 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work on your machine? I tried building the docker image and I get this error Unable to locate package libpython3.10
.ci/cuda11.4.Dockerfile
Outdated
@@ -45,7 +45,7 @@ RUN curl https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh > | |||
bash ~/miniconda.sh -b -p /home/user/conda && \ | |||
rm ~/miniconda.sh | |||
ENV PATH "/home/user/conda/bin:${PATH}" | |||
RUN conda install python=3.8 | |||
RUN conda install python=3.10 | |||
|
|||
# Prettier requires atleast nodejs 10 and actions/checkout requires nodejs 16 | |||
RUN curl -sL https://deb.nodesource.com/setup_current.x > nodesetup.sh && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR. I should have checked this earlier but node setup fails as it runs under non-root user. Can you move this below line 37.
rm -rf /var/lib/apt/lists/*
# Prettier requires atleast nodejs 10 and actions/checkout requires nodejs 16
RUN curl -sL https://deb.nodesource.com/setup_current.x > nodesetup.sh && \
bash - nodesetup.sh && \
apt-get install --no-install-recommends -y nodejs && \
apt-get clean && \
rm -rf /var/lib/apt/lists/*
- python-version: "3.10" | ||
tox-env: "py310" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to add more versions to the matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Upgrade python to 3.10
Fixes CVS-105481
Changes
Checklist