-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Algo] Attribute-based Representations for Accurate and Interpretable Video Anomaly Detection #1040
Conversation
Co-authored-by: Samet Akcay <[email protected]>
Co-authored-by: Samet Akcay <[email protected]>
Co-authored-by: Samet Akcay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean code! I have no major comments just few related to docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts! Looks good to me
import os | ||
import urllib | ||
import warnings | ||
from typing import List, Union |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use the new format or this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should treat everything under clip
as third-party.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, i'll remove my other comments as well
@@ -59,7 +59,7 @@ project: | |||
path: ./results | |||
|
|||
logging: | |||
logger: [] # options: [comet, tensorboard, wandb, csv] or combinations. | |||
logger: [wandb] # options: [comet, tensorboard, wandb, csv] or combinations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope :)
Description
Example predictions:
Known Issues:
Changes
Checklist