Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify codecov upload #1080

Merged
merged 3 commits into from
May 9, 2023
Merged

Modify codecov upload #1080

merged 3 commits into from
May 9, 2023

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Removed the -Z flag as it fails the CI if codecov upload fails
  • Don't pass token if it is not passed to the action.

@ashwinvaidya17 ashwinvaidya17 requested a review from yunchu as a code owner May 9, 2023 09:56
@github-actions github-actions bot added the CI label May 9, 2023
@ashwinvaidya17 ashwinvaidya17 requested a review from samet-akcay May 9, 2023 10:10
@ashwinvaidya17 ashwinvaidya17 changed the title modify codecov upload Modify codecov upload May 9, 2023
samet-akcay
samet-akcay approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this

@samet-akcay samet-akcay merged commit a39c3ec into openvinotoolkit:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@yunchu yunchu Awaiting requested review from yunchu

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwinvaidya17 @samet-akcay