Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [Notebooks] - Simplify the dobot notebooks. #1084

Merged

Conversation

samet-akcay
Copy link
Contributor

Description

  • This PR simplifies the dobot notebooks by removing some redundant, duplicated decoupled code.

  • Fixes # (issue)

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@samet-akcay samet-akcay requested a review from paularamo as a code owner May 10, 2023 16:03
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,526 @@
{
Copy link

@paularamo paularamo May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this in Windows and this line is not working. The line is working is: %pip install anomalib[full]


Reply via ReviewNB

@@ -1,14 +1,16 @@
{
Copy link

@paularamo paularamo May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #10.        metadata_path = weights_path / "openvino" / "meta_data.json"

Typo: metadata instead of meta_data


Reply via ReviewNB

@@ -1,14 +1,16 @@
{
Copy link

@paularamo paularamo May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USB camera instead of US camera. Also I would like to include this:

At this point we will work with the Robot and we need to keep the driver ins the same 501 folder, please copy and paste the files from /501_dobot/dobot_api to /501_dobot. If you don;t have that folder create make sure you are running the notebooks [501a]('link_of the notebook')


Reply via ReviewNB

samet-akcay and others added 4 commits May 11, 2023 09:23
The previous readme file had some errors. It was mentioned NNCF. We must also include the step to create the environment and install Anomalib and jupyter notebooks. Anomalib installation will also be in the notebook, and that is fine.
@samet-akcay samet-akcay changed the title Simplify the dobot notebooks. 📝 Simplify the dobot notebooks. May 12, 2023
@samet-akcay samet-akcay changed the title 📝 Simplify the dobot notebooks. 📝 [Notebooks] - Simplify the dobot notebooks. May 12, 2023
Copy link

@paularamo paularamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Samet!

@samet-akcay samet-akcay merged commit c2fba5e into openvinotoolkit:main May 12, 2023
@samet-akcay samet-akcay deleted the notebooks/install-via-pip branch October 7, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants