-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 [Notebooks] - Simplify the dobot notebooks. #1084
📝 [Notebooks] - Simplify the dobot notebooks. #1084
Conversation
…ooks/install-via-pip
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,526 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this in Windows and this line is not working. The line is working is: %pip install anomalib[full]
Reply via ReviewNB
@@ -1,14 +1,16 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #10. metadata_path = weights_path / "openvino" / "meta_data.json"
Typo: metadata instead of meta_data
Reply via ReviewNB
@@ -1,14 +1,16 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USB camera instead of US camera. Also I would like to include this:
At this point we will work with the Robot and we need to keep the driver ins the same 501 folder, please copy and paste the files from /501_dobot/dobot_api to /501_dobot. If you don;t have that folder create make sure you are running the notebooks [501a]('link_of the notebook')
Reply via ReviewNB
The previous readme file had some errors. It was mentioned NNCF. We must also include the step to create the environment and install Anomalib and jupyter notebooks. Anomalib installation will also be in the notebook, and that is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Samet!
Description
This PR simplifies the dobot notebooks by removing some redundant, duplicated decoupled code.
Fixes # (issue)
Changes
Checklist