Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code-scan workflow to use Trivy #1097

Merged
merged 3 commits into from
May 22, 2023
Merged

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented May 17, 2023

Description

Updated code-scan workflow to use Trivy instead of SNYK

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

tox.ini Outdated Show resolved Hide resolved
.github/workflows/code_scan.yml Outdated Show resolved Hide resolved
.github/workflows/code_scan.yml Show resolved Hide resolved
yunchu and others added 2 commits May 19, 2023 09:58
Co-authored-by: Ashwin Vaidya <[email protected]>
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (854044d) 76.24% compared to head (81d0b13) 76.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files         189      189           
  Lines        7792     7792           
=======================================
  Hits         5941     5941           
  Misses       1851     1851           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samet-akcay
Copy link
Contributor

@yunchu, I'll wait for @ashwinvaidya17's approval, which we could then merge this PR

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashwinvaidya17 ashwinvaidya17 merged commit 5fa148f into main May 22, 2023
@ashwinvaidya17 ashwinvaidya17 deleted the infra/update-code-scan branch May 22, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants