-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate feature map shape patchcore #148
Calculate feature map shape patchcore #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexriedel1! I spotted one small mistake. Other than that the PR looks fine and it's a great addition.
There seem to be some code quality issues, see logs here. Did you use pre-commit? |
now I did :) |
@alexriedel1, I'll run the CI now. We could merge as soon as the tests pass |
ahh sorry I didn't commit after the formatting changes were made, gonna fix it |
Checks complain about some formatting issues. If you could run |
Sorry for making this such a mess :D |
No problem at all! Thanks a lot for the contribution! |
Fixing #40