-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Fix/m1 mac #158
WIP Fix/m1 mac #158
Conversation
@dreaquil, we'll need to move nncf and openvino related requirements to For the openvino imports in the inferencers, we'll first need to check if openvino is installed before importing the package. Alternatively we could import openvino in the corresponding part of the code rather than at the top of the module. For the package version numbers we need some through testing internally to ensure that all the components work fine, and there is no performance degradation in the algorithms. After the check we could use these version numbers. |
@dreaquil, looks like the branch has conflicts to be solved. If you want to get the pr merged, would you be able to resolve the conflicts please? Thanks |
@samet-akcay All done I believe. However, the inclusion of torchtext also created an issue to I had to upgrade it to a later version to find one compatible with m1 mac. I cannot run some of the tests on my machine due to not having a gpu. |
Hi @samet-akcay! Just checking in that the CI is still broken right? |
@dreaquil, almost fixed. we'll try to get it up and running before the end of today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreaquil, these changes causes the CI to fail due linting and mypy issues. I'll try to check if we could find a common ground to install anomalib on M1 and pass the tests.
I've attached the CI logs here, showing where/why the CI fails.
CI-PR-158.log
@dreaquil, looks like black also fails. Can you run if |
Done! here's hoping :) |
CI has passed finally 🎉. I'm gonna be merging the PR now |
Description
Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.
Fixes # (issue)
Requirements incompatible with M1 Mac #150
Changes
Checklist