Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OpenVINO notebooks #1678

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

adrianboguszewski
Copy link
Contributor

@adrianboguszewski adrianboguszewski commented Jan 26, 2024

πŸ“ Description

Fixes partially #1600
Please note NNCF notebook will be fixed as a part of bigger OpenVINO optimization work.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

Copy link

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Adrian Boguszewski <[email protected]>
Signed-off-by: Adrian Boguszewski <[email protected]>
@adrianboguszewski
Copy link
Contributor Author

This PR is ready. Unfortunately, I'm not able to fix the 300 series. It requires a better understanding of the new API.

@adrianboguszewski
Copy link
Contributor Author

@samet-akcay is it ok to merge it?

@samet-akcay
Copy link
Contributor

@samet-akcay is it ok to merge it?

We could merge once the CI passes. Thanks for your effort!

@samet-akcay samet-akcay merged commit 710f863 into openvinotoolkit:main Feb 11, 2024
6 of 7 checks passed
@adrianboguszewski adrianboguszewski deleted the ov-notebooks branch February 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants