-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate train and validation transformations #168
Separate train and validation transformations #168
Conversation
@alexriedel1 the CI has failed due to formatting. We bumped up the black version due to some dependency conflicts, causing some formatting changes. Would you be able to update your black version, and run the formatting again. https://github.com/openvinotoolkit/anomalib/blob/development/tox.ini#L16 |
should be fine now.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a nice enhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexriedel1!
Our CI is broken now. We'll merge this PR once we fix the CI and run the PR one more time.
I just merged the development branch |
This introduces separate training and validation transformation to be defined in the respective model configs.
If nothing is defined, it will fall back to default behaviour at any time.
If only training transformations are defined, validation transformations will be set equal to those.
An alternative for handling this is raising a user warning, that one kind of transformations is defined and the other is not?
If there's something missing or if this should be implemented completely different, let me know.