-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Replace albumentations
with torchvision
transforms
#1706
π Replace albumentations
with torchvision
transforms
#1706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this pr. I've added my initial comments.. Will go for another round
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run this yet but overall I like this over albumentations. It will be one less dependency.
Check out this pull request onΒ See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thanks a lot!
π Description
PR for replacing albumentations transforms with torchvision transforms
β¨ Changes
__getitem__
methods.Mask
format for GT masksInferenceModel
class before exporting.configure_transforms
method of the Lit model. When no transform is passed to the datamodule, this default transform will be used. The default model transform may use theimage_size
parameter from the datamodule to resize the images to the size specified by the user.To be addressed:
Inferencers still use albumentationsCurrent design does not support model-specific transforms (i.e. defining a default transform from the lightning model).Docstrings in the data classes need to be updated to reflect the new signatures.Patchcore fails to export because of theCenterCrop
transform. We may have to implement our own version of this transform to allow exporting.Some models still have theinput_size
parameter, which needs to be removed.CLI tests are failing because the export API has changed.TheConfigAdapter
needs to be updated to reflect the new datamodules API.Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps: