-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove freia
as dependency and include it in anomalib/models/components
#174
Conversation
freia
as dependency and include it in anomalib/models/components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put an additional note in models/components/freia
in which we refer to the source of the module?
@@ -1,6 +1,6 @@ | |||
defusedxml==0.7.1 | |||
requests==2.26.0 | |||
networkx~=2.5 | |||
nncf@ git+https://github.com/openvinotoolkit/nncf@37a830a412e60ec2fd2d84d7f00e2524e5f62777#egg=nncf | |||
nncf==2.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because we cannot upload anomalib to PyPI if the dependencies are git links. This is also the reason why we include freia stuff inside anomalib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes of course. In this case should we request a review from Alexander? I think this specific commit was added to the requirements in his recent PR, so there might be a reason why we don't just use the pypi package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NNCF 2.1.0 is no support features for anomalib, but we are planning release 2.2.0 in 1-2 weeks.
…o fix/sa/add-freia-to-components
Merge branch 'development' of github.com:openvinotoolkit/anomalib into fix/sa/add-freia-to-components
Description
Copy Freia package to anomalib to be able to use pypi.
Fixes
Changes
Checklist