-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Refactor Engine args: Create workspace directory from API #1773
Merged
samet-akcay
merged 52 commits into
openvinotoolkit:main
from
samet-akcay:refactor/engine-args
Feb 29, 2024
Merged
🔨 Refactor Engine args: Create workspace directory from API #1773
samet-akcay
merged 52 commits into
openvinotoolkit:main
from
samet-akcay:refactor/engine-args
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samet-akcay
requested review from
ashwinvaidya17 and
djdameln
as code owners
February 23, 2024 22:09
Something going wrong here. Can you investigate? >>> from anomalib.engine import Engine
>>> from anomalib.models import Padim
>>> from anomalib.data import MVTec
>>>
>>> engine = Engine()
>>> model = Padim()
>>> data = MVTec()
>>>
>>> engine.train(model, datamodule=data)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/djameln/anomalib/src/anomalib/engine/engine.py", line 721, in train
self._setup_workspace(model, train_dataloaders, val_dataloaders, test_dataloaders, datamodule)
File "/home/djameln/anomalib/src/anomalib/engine/engine.py", line 299, in _setup_workspace
root_dir = self._cache.args["default_root_dir"] / model.name / dataset_name / category
TypeError: unsupported operand type(s) for /: 'str' and 'str' |
djdameln
reviewed
Feb 26, 2024
…: 'str' and 'str'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few comments
…b into refactor/engine-args
Signed-off-by: Ashwin Vaidya <[email protected]>
Update unit tests
Signed-off-by: Ashwin Vaidya <[email protected]>
stash changes
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Update unit tests
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
ashwinvaidya17
approved these changes
Feb 29, 2024
Skip AiVAD test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Limitations
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.