-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored-assert-statements-with-explicit-error-handling #1825
Refactored-assert-statements-with-explicit-error-handling #1825
Conversation
Signed-off-by: sahusiddharth <[email protected]>
@samet-akcay @ashwinvaidya17, Pre-Merge Checks / Code-Quality-Checks (pull_request) test is failing because of |
You could ignore it by doing the following. def make_folder3d_dataset( # noqa: C901 I'll create another issue to fix it. It might not be the scope of your PR |
Signed-off-by: sahusiddharth <[email protected]>
Signed-off-by: sahusiddharth <[email protected]>
The logic of a particular asset inside a if statement, was causing some errors, I made necessary changes have changed them now I think all the test cause should pass now. |
@samet-akcay and @ashwinvaidya17, there are 12 test cases that are failing now and I am finding it difficult to trace them back, can you please help me? |
I've restarted the tests |
@ashwinvaidya17, tell me what else needs to done!! |
@sahusiddharth you don't need to do anything else, the tests are passing now. We will review the PR and let you know. Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for your effort
📝 Description
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.