Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored-assert-statements-with-explicit-error-handling #1825

Conversation

sahusiddharth
Copy link
Contributor

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@sahusiddharth
Copy link
Contributor Author

@samet-akcay @ashwinvaidya17, Pre-Merge Checks / Code-Quality-Checks (pull_request) test is failing because of

Screenshot 2024-03-07 at 4 14 01 AM

@samet-akcay
Copy link
Contributor

You could ignore it by doing the following.

def make_folder3d_dataset(  # noqa: C901

I'll create another issue to fix it. It might not be the scope of your PR

Signed-off-by: sahusiddharth <[email protected]>
Signed-off-by: sahusiddharth <[email protected]>
@sahusiddharth
Copy link
Contributor Author

The logic of a particular asset inside a if statement, was causing some errors, I made necessary changes have changed them now I think all the test cause should pass now.

@sahusiddharth
Copy link
Contributor Author

@samet-akcay and @ashwinvaidya17, there are 12 test cases that are failing now and I am finding it difficult to trace them back, can you please help me?

@ashwinvaidya17
Copy link
Collaborator

I've restarted the tests

@sahusiddharth
Copy link
Contributor Author

@ashwinvaidya17, tell me what else needs to done!!

@samet-akcay
Copy link
Contributor

@ashwinvaidya17, tell me what else needs to done!!

@sahusiddharth you don't need to do anything else, the tests are passing now. We will review the PR and let you know. Thanks for your contribution!

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your effort

@samet-akcay samet-akcay merged commit 4c7d7c3 into openvinotoolkit:main Mar 18, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 Refactor assert statements with explicit error handling
3 participants