Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade TorchMetrics #1879

Merged
merged 7 commits into from
Mar 21, 2024
Merged

✨ Upgrade TorchMetrics #1879

merged 7 commits into from
Mar 21, 2024

Conversation

ashwinvaidya17
Copy link
Collaborator

πŸ“ Description

  • Upgrade TorchMetrics

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

ashwinvaidya17 and others added 3 commits March 11, 2024 10:29
* temporarily enable tests on hotfix branches

Signed-off-by: Ashwin Vaidya <[email protected]>

* temporarily enable tests on hotfix branches

Signed-off-by: Ashwin Vaidya <[email protected]>

---------

Signed-off-by: Ashwin Vaidya <[email protected]>
* Migrate to custom precision recall curve

Signed-off-by: Ashwin Vaidya <[email protected]>

* upgrade torchmetrics

Signed-off-by: Ashwin Vaidya <[email protected]>

* Remove check

Signed-off-by: Ashwin Vaidya <[email protected]>

* Fix tests

Signed-off-by: Ashwin Vaidya <[email protected]>

* Fix CLI

Signed-off-by: Ashwin Vaidya <[email protected]>

* Fix PRO computation

Signed-off-by: Ashwin Vaidya <[email protected]>

* Fix typo

Signed-off-by: Ashwin Vaidya <[email protected]>

* Fix tests

Signed-off-by: Ashwin Vaidya <[email protected]>

* Skip normalization tests

Signed-off-by: Ashwin Vaidya <[email protected]>

---------

Signed-off-by: Ashwin Vaidya <[email protected]>
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file CI Tests labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.99%. Comparing base (5babb3b) to head (55700c2).

Files Patch % Lines
src/anomalib/metrics/precision_recall_curve.py 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   81.03%   80.99%   -0.05%     
==========================================
  Files         222      224       +2     
  Lines       10163    10195      +32     
==========================================
+ Hits         8236     8257      +21     
- Misses       1927     1938      +11     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this long awaited fix. I only have a single comment.

src/anomalib/metrics/f1_score.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CI label Mar 21, 2024
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a ton!

Signed-off-by: Ashwin Vaidya <[email protected]>
@samet-akcay samet-akcay enabled auto-merge (squash) March 21, 2024 17:10
@samet-akcay samet-akcay merged commit 686cf84 into main Mar 21, 2024
8 of 9 checks passed
@samet-akcay samet-akcay deleted the hotfix/v1.0.1a branch March 21, 2024 17:11
@samet-akcay samet-akcay added this to the v1.0.1 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants