-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent benchmarking throughput/time #221
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,10 +15,14 @@ | |
# and limitations under the License. | ||
|
||
|
||
import functools | ||
import io | ||
import logging | ||
import math | ||
import multiprocessing | ||
import sys | ||
import time | ||
import warnings | ||
from concurrent.futures import ProcessPoolExecutor, as_completed | ||
from pathlib import Path | ||
from tempfile import TemporaryDirectory | ||
|
@@ -41,9 +45,42 @@ | |
set_in_nested_config, | ||
) | ||
|
||
warnings.filterwarnings("ignore") | ||
|
||
logger = logging.getLogger(__file__) | ||
logging.getLogger("pytorch_lightning").setLevel(logging.ERROR) | ||
logging.getLogger("torchmetrics").setLevel(logging.ERROR) | ||
logging.getLogger("os").setLevel(logging.ERROR) | ||
|
||
|
||
def hide_output(func): | ||
"""Decorator to hide output of the function. | ||
|
||
Args: | ||
func (function): Hides output of this function. | ||
|
||
Raises: | ||
Exception: Incase the execution of function fails, it raises an exception. | ||
|
||
Returns: | ||
object of the called function | ||
""" | ||
|
||
@functools.wraps(func) | ||
def wrapper(*args, **kwargs): | ||
std_out = sys.stdout | ||
sys.stdout = buf = io.StringIO() | ||
try: | ||
value = func(*args, **kwargs) | ||
except Exception as exp: | ||
raise Exception(buf.getvalue()) from exp | ||
sys.stdout = std_out | ||
return value | ||
|
||
return wrapper | ||
|
||
|
||
@hide_output | ||
def get_single_model_metrics(model_config: Union[DictConfig, ListConfig], openvino_metrics: bool = False) -> Dict: | ||
"""Collects metrics for `model_name` and returns a dict of results. | ||
|
||
|
@@ -65,6 +102,7 @@ def get_single_model_metrics(model_config: Union[DictConfig, ListConfig], openvi | |
trainer = Trainer(**model_config.trainer, logger=None, callbacks=callbacks) | ||
|
||
start_time = time.time() | ||
|
||
trainer.fit(model=model, datamodule=datamodule) | ||
|
||
# get start time | ||
|
@@ -218,6 +256,8 @@ def sweep(run_config: Union[DictConfig, ListConfig], device: int = 0, seed: int | |
|
||
# Run benchmarking for current config | ||
model_metrics = get_single_model_metrics(model_config=model_config, openvino_metrics=convert_openvino) | ||
print(model_config.model.name, model_config.dataset.category) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if we want to run |
||
print(model_metrics) | ||
|
||
# Append configuration of current run to the collected metrics | ||
for key, value in run_config.items(): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could set the level in a for loop to avoid the duplicated lines