Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Fix nncf key issue in nightly job #238

Merged
merged 8 commits into from
May 5, 2022
Merged

🔨 Fix nncf key issue in nightly job #238

merged 8 commits into from
May 5, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 commented Apr 19, 2022 •
edited
Loading

Description

  • I have kept nncf disabled in the tests as it might not work in the CI.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@ashwinvaidya17 ashwinvaidya17 added Bug Something isn't working CI labels Apr 19, 2022
@ashwinvaidya17 ashwinvaidya17 changed the title 🚧 WIP: Enable nncf 🚧 WIP: Fix nncf key issue in nightly job Apr 21, 2022
@ashwinvaidya17 ashwinvaidya17 changed the title 🚧 WIP: Fix nncf key issue in nightly job 🔨 Fix nncf key issue in nightly job Apr 21, 2022
samet-akcay
samet-akcay reviewed Apr 21, 2022
View reviewed changes
anomalib/utils/callbacks/__init__.py Outdated
@@ -92,7 +92,7 @@ def get_callbacks(config: Union[ListConfig, DictConfig]) -> List[Callback]:
nncf_config = yaml.safe_load(OmegaConf.to_yaml(config.optimization.nncf))
callbacks.append(
nncf_callback(
config=nncf_config,
nncf_config=nncf_config,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is nncf_callback, config would indicate the nncf_config, wouldn't it? In this case, not sure if we need this renaming here.

@ashwinvaidya17 ashwinvaidya17 changed the title 🔨 Fix nncf key issue in nightly job 🚧 WIP: Fix nncf key issue in nightly job Apr 22, 2022
@ashwinvaidya17 ashwinvaidya17 changed the title 🚧 WIP: Fix nncf key issue in nightly job 🔨 Fix nncf key issue in nightly job May 4, 2022
@ashwinvaidya17 ashwinvaidya17 requested a review from djdameln May 4, 2022 12:14
@ashwinvaidya17 ashwinvaidya17 merged commit 60d9c12 into development May 5, 2022
@ashwinvaidya17 ashwinvaidya17 deleted the fix/av/nncf branch May 5, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwinvaidya17 @samet-akcay @djdameln