Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚜 Refactor loss computation #364

Merged
merged 6 commits into from
Jun 13, 2022
Merged

🚜 Refactor loss computation #364

merged 6 commits into from
Jun 13, 2022

Conversation

djdameln
Copy link
Contributor

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay requested review from samet-akcay and ashwinvaidya17 and removed request for samet-akcay June 13, 2022 09:18
samet-akcay
samet-akcay requested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a lot cleaner now! Only a single comment

anomalib/models/fastflow/loss.py Outdated
jacobians (List[Tensor]): Log of the jacobian determinants from the fastflow model.

Returns:
Tensor: _description_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a leftover from the previous PR, but would be good to add a description here in this PR.

@samet-akcay samet-akcay added Refactor Refactoring is needed Model labels Jun 13, 2022
@samet-akcay samet-akcay changed the title Refactor loss computation 🚜 Refactor loss computation Jun 13, 2022
ashwinvaidya17
ashwinvaidya17 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor!

@samet-akcay samet-akcay merged commit f0e26fe into development Jun 13, 2022
@samet-akcay samet-akcay deleted the da/refactor-loss branch June 13, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
Model Refactor Refactoring is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move loss to lightning module/separate module
3 participants
@djdameln @ashwinvaidya17 @samet-akcay