Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inference + Visualization #390

Merged
merged 16 commits into from
Jul 1, 2022
Merged

Inference + Visualization #390

merged 16 commits into from
Jul 1, 2022

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Jun 28, 2022 •
edited by samet-akcay
Loading

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

djdameln added 6 commits May 25, 2022 15:58
@djdameln
Visualizer improvements Part II (#298)
ef4190d 
* add methods for adding labels to image

* refactor visualizer

* move add_label to post processing helpers

* fix tests

* support single image in visualizer

* call generate

* revert default task type

* typing

* refactor inferencer and visualizer

* add torch inference entrypoint

* revert torch inferencer for backward compatibility

* add torch inferencer to init files

* pause visualization

* openvino.py -> openvino_inference.py

* address comments

* remove unused argument

* remove depracation warning
@djdameln
📜 Add Inference Documentation (#308)
1ed2f1e 
* add inference and export guides

* finish sentence

* fix typo

* add to index, change required field
@djdameln
merge develop
55a2054
@djdameln
🚜 Visualizer refactor pt3 (#374)
46dc93c 
* make saving and showing of visualizations configurable

* make saving and showing of visualizations configurable

* fix visualizer callback tests

* remove unused imports

* fix openvino test

* add comments
@djdameln
Visualizer refactor pt4 (#379)
6cad624 
* make visualization mode configurable

* change default visualization mode

* value checks

* check mask range, move save and show to visualizer

* fix visualizer tests

* change pred_mask value check

* address circular import

* address mypy issue

* fix visualizer test and mypy

* fix openvino tests
@djdameln
solve merge conflicts
aca759b
samet-akcay
samet-akcay reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i've got couple of comments, but overall, this a lot better than what we currently have.

anomalib/utils/callbacks/model_loader.py Outdated Show resolved Hide resolved
tools/inference.py Outdated Show resolved Hide resolved
tools/inference.py Outdated Show resolved Hide resolved
anomalib/utils/callbacks/__init__.py Show resolved Hide resolved
ashwinvaidya17
ashwinvaidya17 requested changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts! I have a few comments.

tools/inference.py Outdated Show resolved Hide resolved
docs/source/guides/inference.rst Outdated Show resolved Hide resolved
docs/source/guides/inference.rst Outdated Show resolved Hide resolved
anomalib/utils/loggers/tensorboard.py Show resolved Hide resolved
ashwinvaidya17
ashwinvaidya17 reviewed Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment :)

tools/inference/gradio_inference.py Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@samet-akcay samet-akcay linked an issue Jul 1, 2022 that may be closed by this pull request
Label Prediction with Confidence score #326
Closed
@samet-akcay samet-akcay merged commit 98bd9ff into development Jul 1, 2022
@samet-akcay samet-akcay deleted the feature/visualization-inference-refactor branch July 1, 2022 11:57
@samet-akcay samet-akcay mentioned this pull request Jul 8, 2022
Merged
11 tasks
This was linked to issues Jul 11, 2022
Refactor torch inference #301
Closed
When change the image size I got the problem on the inference step #394
Closed
@ashwinvaidya17 ashwinvaidya17 mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@djdameln @ashwinvaidya17 @samet-akcay