Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visualizer for classification, mode=simple #442

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Fix visualizer for classification, mode=simple #442

merged 3 commits into from
Jul 20, 2022

Conversation

ORippler
Copy link
Contributor

@ORippler ORippler commented Jul 18, 2022 •
edited
Loading

Description

  • Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

    • Fix Visualizer for AD-only methods by referring to image_result.image instead of image_result.heat_map for task==classification since AD-only methods don't produce heat-maps.
    • Add integration test for AnomalyModule/Visualizer, where we test that both AD-only and segmentation modules work with Visualizers in all combinations of task and mode

  • Fixes Visualizer with task=classification and mode=simple fails #441

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

ORippler added 3 commits July 18, 2022 10:04
@ORippler
Fix visualizer for classification, mode=simple
77a1ceb 
Need to refer to `image_result.image` instead of `image_result.heat_map`
since AD-only methods don't produce heat-maps
@ORippler
Add Integration test for AnomalyModule/Visualizer
c36d366 
Check that the combination of Visualizer in
[°segmentation", "classification"], ["full", "simple"] works with both
AD-only and segmentation-type models
@ORippler
Simplify code
c2d376f
@ORippler ORippler marked this pull request as ready for review July 19, 2022 09:58
samet-akcay
samet-akcay approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

ashwinvaidya17
ashwinvaidya17 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@samet-akcay samet-akcay merged commit c826c71 into openvinotoolkit:development Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualizer with task=classification and mode=simple fails
3 participants
@ORippler @ashwinvaidya17 @samet-akcay