-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix onnx export by rewriting GaussianBlur #476
Conversation
I changed the |
Reame variable to something other than `input`
As far as I'm aware there was no reason. It would be a good idea to inherit nn.Module for every AnomalyMapGenerator for consistency. It could perhaps be another pr since the scope of this pr is gaussian blur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this! I'll approve the PR once we settle on the appropriate location to store the new GaussianBlur class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying and fixing this! I am fine with the changes but I'd wait for the consensus from others regarding the location of blur.py before merging.
Moved it to |
Description
GaussianBlur2d
to no longer rely on input shapes for calculation of the kernel size. As a caveat, now the number of channels need to be specified during initChanges
Checklist