Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Perlin augmenter for non divisible image sizes #490

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

djdameln
Copy link
Contributor

Description

  • Perlin noise augmentation for DRAEM was instable for image sizes that were not a power of 2. This PR adds a quick fix for this issue by generating the Perlin noise mask with a dimensionality equal to the nearest power of 2 and then cropping back to the original image size.
  • This temporarily fixes the issues with DRAEM until we create our own implementation of Perlin noise.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay merged commit 2a0dccd into main Aug 10, 2022
@samet-akcay samet-akcay deleted the da/fix-perlin-augmenter branch August 10, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants