Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Set normalization method from anomaly module #530

Merged
merged 1 commit into from
Sep 2, 2022
Merged

🐞 Set normalization method from anomaly module #530

merged 1 commit into from
Sep 2, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

@ashwinvaidya17 ashwinvaidya17 requested review from djdameln and samet-akcay and removed request for djdameln August 31, 2022 13:57
@ashwinvaidya17 ashwinvaidya17 changed the title Set normalization method from anomaly module 🐞 Set normalization method from anomaly module Aug 31, 2022
samet-akcay
samet-akcay approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for now, thanks. I was wondering how we are going to handle when you implement more normalization methods. Adding those methods in _load_normalization_class?

@djdameln djdameln merged commit c7ca76d into main Sep 2, 2022
@djdameln djdameln deleted the ashwin/fix_523_load_state_dict branch September 2, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwinvaidya17 @samet-akcay @djdameln