correct folder mask path

[jpcbertoldo]

Description

Fixes #659

I did not create new tests but I added an assertion in make_dataset which should not make the method slower and would force any similar issue to appear much earlier (first time I saw it was after the whole training, which is quite incovenient for a basic bug).

Changes

• Bug fix (non-breaking change which fixes an issue)
• Refactor (non-breaking change which refactors the code base)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• My code follows the pre-commit style and check guidelines of this project.
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes

[jpcbertoldo]

@samet-akcay this one is quite simple, can i get a review, plz?

[samet-akcay]

Thanks for spotting this @jpcbertoldo! Yeah, I agree, it's good to check if the files exist. Annoying to figure it out during training or evaluation.

[ashwinvaidya17]

Thanks! I have one comment

[jpcbertoldo]

done @ashwinvaidya17

[ashwinvaidya17]

Thanks!

[djdameln]

I'm fine with the changes, though it might make sense to target these changes to the datamodules feature branch instead of the main branch. That way it would be part of the datamodules redesign and we would avoid conflicts.

[jpcbertoldo]

I'm fine with the changes, though it might make sense to target these changes to the datamodules feature branch instead of the main branch. That way it would be part of the datamodules redesign and we would avoid conflicts.

@djdameln I thought the same and forgot to write it. haha.

Although, I was trying to use the branch and could not really use the CLI (just got tired of debugging and went back to main), so I'm more tending to work on main for the sake of practicity.

Can we find something smart to do about it? Like, at lest keep a least of PRs to re-do as long as it remains simple (like this one).

[djdameln]

Alright, let's merge this to main for now. I've created an issue so that we don't forget to add it to the feature branch later on. Any other changes that we need to repeat on the feature branch we could append them to this checklist here.

[jpcbertoldo]

Alright, let's merge this to main for now. I've created an issue so that we don't forget to add it to the feature branch later on. Any other changes that we need to repeat on the feature branch we could append them to this checklist here.

NIce! Thanks @djdameln !

[jpcbertoldo]

Was or has this been planned to be fixed?

[samet-akcay]

I think it's alright. We could merge this.