Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞Patch Timm Feature Extractor #714

Merged
merged 3 commits into from
Nov 17, 2022
Merged

🐞Patch Timm Feature Extractor #714

merged 3 commits into from
Nov 17, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Add eval to feture extractor and use torch.no_grad
  • Fixes inconsistent performance between runs

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@ashwinvaidya17 ashwinvaidya17 mentioned this pull request Nov 16, 2022
Merged
8 tasks
ashwinvaidya17 pushed a commit that referenced this pull request Nov 16, 2022
Copy changes from #714 for tests
70007ce
djdameln
djdameln approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 0ef8ab1 into main Nov 17, 2022
@samet-akcay samet-akcay deleted the ashwin/fix_feature_extractor branch November 17, 2022 04:15
NagatoYuki0943 added a commit to NagatoYuki0943/anomalib that referenced this pull request Nov 17, 2022
@NagatoYuki0943
Merge pull request #14 from openvinotoolkit/main
a122a15 
🐞Patch Timm Feature Extractor (openvinotoolkit#714)
ashwinvaidya17 added a commit that referenced this pull request Nov 25, 2022
@ashwinvaidya17 @samet-akcay
✨ Add torchfx feature extractor (#675)
0bf9706 
* Add torchfx feature extractor

* Fix docstrings

* Support loading models from custom class

* Convert torchfx feature extractor to class for consistency

* Update tests

* Add FeatureExtractor method for backward compatibility

* fix imports

* Copy changes from #714 for tests

* Revert naming to FeatureExtractor

* Revert removing eval

* User backbone params for torchfx feature extractor

* Remove unnecessary class parameter

* Address PR comments

* Pass locally defined class + add tests for it

* Remove hparams from dummy model

* Address codacy issues

Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Samet Akcay <[email protected]>
@NagatoYuki0943 NagatoYuki0943 mentioned this pull request Nov 25, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwinvaidya17 @samet-akcay @djdameln