-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Detection task type #732
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
64008c3
add basic support for detection task
djdameln bcd03d4
use enum for task type
djdameln ca427fb
formatting
djdameln 69b83b4
small bugfix
djdameln 30c4368
add unit tests for bounding box conversion
djdameln 3c0cfec
update error message
djdameln 037c1e5
use as_tensor
djdameln abea835
typing and docstring
djdameln c060333
explicit keyword arguments
djdameln bf573d1
simplify bbox handling in video dataset
djdameln b7f1b66
docstring consistency
djdameln 7f60ea2
add missing licenses
djdameln eb87358
add whitespace for readability
djdameln 4c3a6b1
add missing license
djdameln cec6138
Update anomalib/data/utils/boxes.py
djdameln d13ce5b
Revert "Update anomalib/data/utils/boxes.py"
djdameln 0e0dc80
add test case for custom collate function
djdameln 5ead1ad
docstring
djdameln 44812d6
add integration tests for detection dataloading
djdameln d9304aa
extend and clean up datamodules tests
djdameln caf0867
add detection task type to visualizer tests
djdameln 67312fc
Merge branch 'feature/datamodules' into da/detection-task-type
djdameln d63a7b7
only show pred_boxes during inference
djdameln 7ec5fa4
add detection support for torch inference
djdameln d74bf41
add detection support for openvino inference
djdameln 39cf0ac
test inference for all task types
djdameln f3d00d8
pylint
djdameln 9962e8c
merge latest changes
djdameln 5a055f2
merge feature branch
djdameln File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
"""Task type enum.""" | ||
|
||
djdameln marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# Copyright (C) 2022 Intel Corporation | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
from enum import Enum | ||
|
||
|
||
class TaskType(str, Enum): | ||
"""Task type used when generating predictions on the dataset.""" | ||
|
||
CLASSIFICATION = "classification" | ||
DETECTION = "detection" | ||
SEGMENTATION = "segmentation" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this be used by models and other components as well? If so, would it be an idea to move it to a place that would be accessible by other components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not super happy with the location of
TaskType
but couldn't think of a better place. Maybe somewhere inanomalib/config
would work? @ashwinvaidya17 any ideas?