Add CFA model #783
Merged
Add CFA model #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Image-Level AUC | ||
|
|
||
| | | ResNet-18 | Wide ResNet50 | |
There was a problem hiding this comment.
Minor issue but we use a horizontal layout in other models.
There was a problem hiding this comment.
yeah, but we need to scroll to the side when we have the horizontal layout. I think this one looks better than the old one. If you guys also agree, we could maybe change the layout for other models?
| normalize: bool = True, | ||
| border_type: str = "reflect", | ||
| padding: str = "same", | ||
| ) -> None: | ||
| """Initialize model, setup kernel etc.. | ||
|
|
||
| Args: | ||
| kernel_size (Union[Tuple[int, int], int]): size of the Gaussian kernel to use. | ||
| sigma (Union[Tuple[float, float], float]): standard deviation to use for constructing the Gaussian kernel. |
There was a problem hiding this comment.
Not part of this PR but should we move these init_args above to make it consistent with other classes?
djdameln
reviewed
Dec 16, 2022
| Returns: | ||
| int: Kernel size. | ||
| """ | ||
| return 2 * int(4.0 * sigma_val + 0.5) + 1 |
There was a problem hiding this comment.
We use the same computation in Padim (here), and maybe other models as well. Would be good to use this function there as well.
Co-authored-by: Dick Ameln <[email protected]>
…ib into feature/model/cfa
This reverts commit 7752bb3.
NagatoYuki0943
added a commit
to NagatoYuki0943/anomalib
that referenced
this pull request
Jan 12, 2023
Add CFA model (openvinotoolkit#783)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO:
Changes
Checklist