Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #87

Merged
merged 24 commits into from
Feb 8, 2022
Merged

Refactor #87

merged 24 commits into from
Feb 8, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Refactor repository according to discussion

  • Fixes # (issue)

Changes

  • Move PR template to root of .github folder.

Checklist:

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

samet-akcay
samet-akcay reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashwinvaidya17. Much more organised now. Just couple of opens that we could discuss. Most of them are related to relative-imports and storing the base classes.

anomalib/data/mvtec.py Outdated Show resolved Hide resolved
anomalib/deploy/inferencers/base.py Outdated Show resolved Hide resolved
anomalib/models/stfpm/model.py Outdated Show resolved Hide resolved
anomalib/utils/loggers/wandb.py Outdated Show resolved Hide resolved
tests/deploy/test_inferencer.py Outdated Show resolved Hide resolved
anomalib/models/dfkde/model.py Outdated Show resolved Hide resolved
anomalib/deploy/inferencers/torch.py Outdated Show resolved Hide resolved
anomalib/deploy/optimize.py Outdated Show resolved Hide resolved
anomalib/models/components/dimensionality_reduction/pca.py Show resolved Hide resolved
anomalib/models/dfkde/normality_model.py Outdated Show resolved Hide resolved
blakshma
blakshma reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@blakshma blakshma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwinvaidya17 thanks for this refactoring. New structure looks pretty clean.

anomalib/deploy/inferencers/torch.py Outdated Show resolved Hide resolved
anomalib/deploy/inferencers/torch.py Outdated Show resolved Hide resolved
samet-akcay
samet-akcay reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the this iteration! I think we're getting there...

anomalib/models/components/sampling/k_center_greedy.py Show resolved Hide resolved
anomalib/models/patchcore/model.py Outdated Show resolved Hide resolved
anomalib/base/__init__.py Outdated Show resolved Hide resolved
@ashwinvaidya17 ashwinvaidya17 mentioned this pull request Feb 2, 2022
Closed
@ashwinvaidya17 ashwinvaidya17 marked this pull request as draft February 3, 2022 14:15
@samet-akcay samet-akcay marked this pull request as ready for review February 7, 2022 12:22
ashwinvaidya17
ashwinvaidya17 commented Feb 8, 2022
View reviewed changes
Copy link
Collaborator Author

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see one minor issue. Maybe we can address that in a different PR. There are some duplicate tests and some tests outside the pre_merge and nightly folder. I have removed the duplicate tests in the benchmarking PR.

tests/helpers/model.py Outdated Show resolved Hide resolved
tests/models/test_model.py
@@ -0,0 +1,182 @@
"""Test Models."""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be deleted

@samet-akcay samet-akcay merged commit d13e452 into development Feb 8, 2022
@samet-akcay samet-akcay deleted the feature/refactor branch February 8, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakshma blakshma blakshma left review comments

@djdameln djdameln djdameln approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

@ugenc-intel ugenc-intel Awaiting requested review from ugenc-intel

@nahuja-intel nahuja-intel Awaiting requested review from nahuja-intel

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashwinvaidya17 @samet-akcay @djdameln @blakshma