-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up PyTorch Lightning version to v1.9.* #870
Bump up PyTorch Lightning version to v1.9.* #870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just one question.
auto_select_gpus: false | ||
benchmark: false | ||
check_val_every_n_epoch: 1 | ||
enable_checkpointing: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these new parameters also work with 1.6.x or are they only for versions greater than 1.7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question, haven't checked 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these new parameters also work with 1.6.x or are they only for versions greater than 1.7.0
@ashwinvaidya17, the only parameter that PyTorch Lightning v1.6.* does not support was inference_mode
. Since we do not use it anywhere in the code base yet, I've removed it from the configs and confirmed that the changes are backward-compatible.
…b.com:openvinotoolkit/anomalib into refactor/sa/bump-up-pytorch-lightning-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
…tor/sa/bump-up-pytorch-lightning-version
…tor/sa/bump-up-pytorch-lightning-version
* check extras dependencies in loggers * Add recreate to workflow * Revert -r flag * Fix mocks --------- Co-authored-by: Ashwin Vaidya <[email protected]>
…tor/sa/bump-up-pytorch-lightning-version
…b.com:openvinotoolkit/anomalib into refactor/sa/bump-up-pytorch-lightning-version
Codecov ReportBase: 86.88% // Head: 86.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
- Coverage 86.88% 86.77% -0.12%
==========================================
Files 165 165
Lines 6331 6319 -12
==========================================
- Hits 5501 5483 -18
- Misses 830 836 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What does this PR do?
Why is this change needed?
Changes
Checklist