Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up PyTorch Lightning version to v1.9.* #870

Merged
merged 39 commits into from
Feb 7, 2023

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Jan 27, 2023

What does this PR do?

  • Bump up PyTorch Lightning version to 1.9.0

Why is this change needed?

  • anomalib currently support PL 1.6.* and CLI has new functionalities after v1.7.0. In addition, there are some security related issues, which v1.9.* addresses.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added Callbacks CLI Data Dependencies Pull requests that update a dependency file Logger labels Jan 27, 2023
@samet-akcay samet-akcay changed the title Refactor/sa/bump up pytorch lightning version Bump up PyTorch Lightning version Jan 27, 2023
@samet-akcay samet-akcay changed the title Bump up PyTorch Lightning version Bump up PyTorch Lightning version to v1.9.* Jan 27, 2023
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one question.

auto_select_gpus: false
benchmark: false
check_val_every_n_epoch: 1
enable_checkpointing: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these new parameters also work with 1.6.x or are they only for versions greater than 1.7.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question, haven't checked 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these new parameters also work with 1.6.x or are they only for versions greater than 1.7.0

@ashwinvaidya17, the only parameter that PyTorch Lightning v1.6.* does not support was inference_mode. Since we do not use it anywhere in the code base yet, I've removed it from the configs and confirmed that the changes are backward-compatible.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot added the Setup label Feb 3, 2023
@github-actions github-actions bot added the Tools label Feb 3, 2023
@github-actions github-actions bot added the CI label Feb 3, 2023
@github-actions github-actions bot added the Tests label Feb 5, 2023
ashwinvaidya17 and others added 4 commits February 6, 2023 16:56
* check extras dependencies in loggers

* Add recreate to workflow

* Revert -r flag

* Fix mocks

---------

Co-authored-by: Ashwin Vaidya <[email protected]>
…b.com:openvinotoolkit/anomalib into refactor/sa/bump-up-pytorch-lightning-version
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 86.88% // Head: 86.77% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (b1f52b6) compared to base (476655a).
Patch coverage: 88.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   86.88%   86.77%   -0.12%     
==========================================
  Files         165      165              
  Lines        6331     6319      -12     
==========================================
- Hits         5501     5483      -18     
- Misses        830      836       +6     
Impacted Files Coverage Δ
anomalib/data/btech.py 84.21% <ø> (-0.54%) ⬇️
anomalib/models/ganomaly/lightning_model.py 100.00% <ø> (ø)
anomalib/utils/callbacks/export.py 100.00% <ø> (ø)
anomalib/utils/callbacks/graph.py 40.00% <ø> (-7.06%) ⬇️
anomalib/utils/callbacks/metrics_configuration.py 100.00% <ø> (ø)
anomalib/utils/callbacks/min_max_normalization.py 91.11% <ø> (-0.38%) ⬇️
anomalib/utils/callbacks/model_loader.py 100.00% <ø> (ø)
...b/utils/callbacks/post_processing_configuration.py 100.00% <ø> (ø)
anomalib/utils/callbacks/tiler_configuration.py 50.00% <ø> (-4.55%) ⬇️
anomalib/utils/callbacks/timer.py 100.00% <ø> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samet-akcay samet-akcay merged commit d390fb5 into main Feb 7, 2023
@samet-akcay samet-akcay deleted the refactor/sa/bump-up-pytorch-lightning-version branch February 7, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants