Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Add OpenVINO Inference to getting started notebook. #897

Conversation

samet-akcay
Copy link
Contributor

Description

  • This PR updates the getting started notebook to include the OpenVINO inference. The primary goal is to quickly explain the connection between "anomalib" and "OpenVINO," particularly to people who are unfamiliar with either of these libraries.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1407cfc) 86.77% compared to head (ded25a5) 86.77%.

❗ Current head ded25a5 differs from pull request most recent head b352d57. Consider uploading reports for the commit b352d57 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         165      165           
  Lines        6319     6319           
=======================================
  Hits         5483     5483           
  Misses        836      836           
Impacted Files Coverage Δ
anomalib/data/utils/augmenter.py 98.48% <0.00%> (ø)
anomalib/pre_processing/tiler.py 100.00% <0.00%> (ø)
anomalib/models/csflow/torch_model.py 91.86% <0.00%> (ø)
anomalib/models/rkde/region_extractor.py 85.41% <0.00%> (ø)
anomalib/models/ganomaly/lightning_model.py 100.00% <0.00%> (ø)
anomalib/deploy/inferencers/torch_inferencer.py 87.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we show OpenVINO inference here, and not PL inference. Isn't PL inference the recommended way to run inference?

@samet-akcay samet-akcay merged commit 9fd0e5d into openvinotoolkit:main Mar 3, 2023
@samet-akcay samet-akcay deleted the notebooks/add-openvino-inference-to-getting-started branch March 3, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants