-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove torchvision and torchtext #903
Remove torchvision and torchtext #903
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 165 165
Lines 6319 6322 +3
=======================================
+ Hits 5483 5486 +3
Misses 836 836
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this safe? How do we know the correct version is installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is torchtext automatically installed? If I remember correctly, SC docker files contain additional torchtext dependency in the base image. But that maybe just for fixing the version.
We don't have a check for torch, but do have for these. Actually this would be even more problematic |
Alright. Let's roll with this then |
@ashwinvaidya17, I also feel that we should also have |
Description
torchvision
andtorchtext
from the base requirements.Changes
Checklist