Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding robot/training notebooks #926

Merged
merged 7 commits into from
Feb 24, 2023
Merged

adding robot/training notebooks #926

merged 7 commits into from
Feb 24, 2023

Conversation

paularamo
Copy link

Description

  • Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

  • Fixes # (issue)

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@paularamo
Copy link
Author

image

The heat map looks weird. Apart of that, the two notebooks are working well. 501_1 is working pretty well with the robot setup.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour of the following convention for the notebooks and the dobot folder

notebooks/500_use_cases
└── 501_Dobot
    ├── 501a_Dataset_creation_and_Inference_with_a_robotic_arm.ipynb
    ├── 501b_Training_a_model_with_cubes_from_a_robotic_arm.ipynb

There are some issues in the feature branch due to which the CI is failing.

.gitignore Outdated Show resolved Hide resolved
notebooks/500_use_cases/501_dobot/cubes_config.yaml Outdated Show resolved Hide resolved
notebooks/500_use_cases/501_dobot/cubes_config.yaml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
notebooks/500_use_cases/501_dobot/README.md Outdated Show resolved Hide resolved
@ashwinvaidya17
Copy link
Collaborator

I am merging this to the feature branch. I'll create a new PR which addressed the linting issues.

@ashwinvaidya17 ashwinvaidya17 merged commit 89b1ca0 into openvinotoolkit:feature/notebooks/usecases/dobot Feb 24, 2023
ashwinvaidya17 added a commit that referenced this pull request Feb 24, 2023
* Use case Dobot - WIP commit (#884)

* WIP commit

* training via config file and robot control

* 2 notebooks robot control

* Removed utils directory from notebooks/500_use_cases

* Removed utils directory from `notebooks/500_use_cases` (#911)

Removed utils directory from notebooks/500_use_cases

* Download the dataset and the api from anomalib assets

* adding readme file

* adding instructions

* adding instructions

* adding instructions

* adding instructions

* adding instructions

* adding instructions

* adding instructions

* adding instructions

* adding instructions

* adding instructions

* Update README.md

* Model training is done via API now

* Fixed the bugs spotted by Paula

* directories for robot

* adding robot/training notebooks (#926)

* adding robot/training notebooks

* normalization issue fixed

* adding imagenet for OV inferencing

* Remove unused header

* Add new line at the end of file

* Fix dataset path

* Fix formatting

---------

Co-authored-by: Ashwin Vaidya <[email protected]>

* Dobot (#927)

* Add GitPython to requirements/base.txt (#906)

* Add GitPython to requirements/base.txt

Fixes #905 
(should this go in `base.txt`, or `extras.txt`?)

* Moved GitPython requirement from base to extra

* adding robot/training notebooks

* Modify notebooks

* Run pre-commit

* stash changes

* Refactor files + delete old

* Removve checkponit

* Revert header

* Address PR comments

* Remove output

---------

Co-authored-by: Paula Ramos <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>

* Move requirements + ignore dobot notebooks

---------

Co-authored-by: Paula Ramos <[email protected]>
Co-authored-by: Samet <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants