-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove config dependency from OpenVINOInferencer
#939
Remove config dependency from OpenVINOInferencer
#939
Conversation
* WIP commit * training via config file and robot control * 2 notebooks robot control
…it#911) Removed utils directory from notebooks/500_use_cases
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 176 176
Lines 6812 6808 -4
=======================================
- Hits 5541 5538 -3
+ Misses 1271 1270 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -37,7 +37,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -37,7 +37,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Only a single minor comment
anomalib/models/padim/config.yaml
Outdated
@@ -63,7 +63,7 @@ logging: | |||
log_graph: false # Logs the model graph to respective logger. | |||
|
|||
optimization: | |||
export_mode: null #options: onnx, openvino | |||
export_mode: openvino #options: onnx, openvino |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this was committed by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have some general comments.
While the cube_config is not used anywhere we might have to keep it because the blog post might reference it. When Paula was checking the differences in the outputs by API and CLI she tried running the CLI as well. We had fixed one issue related to normalization in the config even after the API in the notebooks was giving correct result. Maybe we can run it by her.
…tor/sa/remove-config-dependency-from-openvino-inferencer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@samet-akcay Could we reopen this PR? I see some errors in the 501 notebooks. OpenVINO model is not saved properly in the expected path and also the config file is referenced in the blog, and the link is broken. I will paste here the error I had so far: In the folder the IR model is not in the expected place: Appreciate your help on this issue. |
Description
config
argument. Ideally, the parameters withinconfig
should be inmetadata
. This PR addresses this problem.Changes
Checklist